[
https://issues.apache.org/jira/browse/GOBBLIN-2065?focusedWorklogId=918454&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918454
]
ASF GitHub Bot logged work on GOBBLIN-2065:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/24 02:17
Start Date: 09/May/24 02:17
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3948:
URL: https://github.com/apache/gobblin/pull/3948#discussion_r1594884624
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/core/GobblinServiceHATest.java:
##########
@@ -255,6 +251,8 @@ public void cleanUp() throws Exception {
cleanUpDir(COMMON_SPEC_STORE_PARENT_DIR);
mysql.stop();
+ // `.close()` to avoid (in the aggregate, across multiple suites) -
java.sql.SQLNonTransientConnectionException: Too many connections
+ testMetastoreDatabase.close();
Review Comment:
true, but the canonical rule is to close in reverse order of opening.
because, this was the first one to be opened, it should be the last closed
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/core/GobblinServiceHATest.java:
##########
@@ -255,6 +251,8 @@ public void cleanUp() throws Exception {
cleanUpDir(COMMON_SPEC_STORE_PARENT_DIR);
mysql.stop();
+ // `.close()` to avoid (in the aggregate, across multiple suites) -
java.sql.SQLNonTransientConnectionException: Too many connections
+ testMetastoreDatabase.close();
Review Comment:
true, but the canonical rule is to close in reverse order of opening. as
this was the first one to be opened, it should be the last closed
Issue Time Tracking
-------------------
Worklog Id: (was: 918454)
Time Spent: 1h 40m (was: 1.5h)
> close ITestMetastoreDatabase in all tests
> -----------------------------------------
>
> Key: GOBBLIN-2065
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2065
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> if test db is not closed, it will eventually give `TooManyConnections`
> exception
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
