[
https://issues.apache.org/jira/browse/GOBBLIN-2065?focusedWorklogId=918453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-918453
]
ASF GitHub Bot logged work on GOBBLIN-2065:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/24 02:15
Start Date: 09/May/24 02:15
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3948:
URL: https://github.com/apache/gobblin/pull/3948#discussion_r1594883908
##########
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/spec_store/MysqlBaseSpecStoreTest.java:
##########
@@ -48,23 +48,23 @@ public class MysqlBaseSpecStoreTest {
private static final String PASSWORD = "testPassword";
private static final String TABLE = "base_spec_store";
+ private ITestMetastoreDatabase testDb;
Review Comment:
although this is more rare w/ tests (however we DO have a few derived test
classes), but anyway a `static` resource that needs closing doesn't really play
well w/ subclassing
Issue Time Tracking
-------------------
Worklog Id: (was: 918453)
Time Spent: 1.5h (was: 1h 20m)
> close ITestMetastoreDatabase in all tests
> -----------------------------------------
>
> Key: GOBBLIN-2065
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2065
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> if test db is not closed, it will eventually give `TooManyConnections`
> exception
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
