mike-jumper commented on code in PR #717:
URL: https://github.com/apache/guacamole-client/pull/717#discussion_r854734426
##########
guacamole-docker/README.md:
##########
@@ -55,31 +55,31 @@ Deploying Guacamole with PostgreSQL authentication
--------------------------------------------------
docker run --name some-guacamole --link some-guacd:guacd \
- --link some-postgres:postgres \
- -e POSTGRES_DATABASE=guacamole_db \
- -e POSTGRES_USER=guacamole_user \
- -e POSTGRES_PASSWORD=some_password \
- -e POSTGRES_DATABASE_FILE=/run/secrets/<secret_name> \
- -e POSTGRES_USER_FILE=/run/secrets/<secret_name> \
- -e POSTGRES_PASSWORD_FILE=/run/secrets/<secret_name> \
+ --link some-postgresql:postgresql \
Review Comment:
> This particular line may actually need to not be changed ... Thoughts on
this one?
Hm ... I'm not sure off-hand. Most of my Docker deployments have been
docker-compose for a while, and I recall someone mentioning that Docker had
deprecated `--link`.
I think the "postgresql" part is used by Docker to generate environment
variables, and so would need to match whatever the container uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
