necouchman commented on code in PR #717:
URL: https://github.com/apache/guacamole-client/pull/717#discussion_r859706237
##########
guacamole-docker/README.md:
##########
@@ -55,31 +55,31 @@ Deploying Guacamole with PostgreSQL authentication
--------------------------------------------------
docker run --name some-guacamole --link some-guacd:guacd \
- --link some-postgres:postgres \
- -e POSTGRES_DATABASE=guacamole_db \
- -e POSTGRES_USER=guacamole_user \
- -e POSTGRES_PASSWORD=some_password \
- -e POSTGRES_DATABASE_FILE=/run/secrets/<secret_name> \
- -e POSTGRES_USER_FILE=/run/secrets/<secret_name> \
- -e POSTGRES_PASSWORD_FILE=/run/secrets/<secret_name> \
+ --link some-postgresql:postgresql \
Review Comment:
@jbpaux I agree that removing link is different in scope from this, so no
need to worry about that.
For the renaming, I would think something simple at the beginning of the
script that checks for the old variables and assigns the values to the new
variables would probably work? That way the remaining checks, here, would only
have to consider a single set of variables - the "correctly" named ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
