jbpaux commented on code in PR #717:
URL: https://github.com/apache/guacamole-client/pull/717#discussion_r854893904
##########
guacamole-docker/README.md:
##########
@@ -55,31 +55,31 @@ Deploying Guacamole with PostgreSQL authentication
--------------------------------------------------
docker run --name some-guacamole --link some-guacd:guacd \
- --link some-postgres:postgres \
- -e POSTGRES_DATABASE=guacamole_db \
- -e POSTGRES_USER=guacamole_user \
- -e POSTGRES_PASSWORD=some_password \
- -e POSTGRES_DATABASE_FILE=/run/secrets/<secret_name> \
- -e POSTGRES_USER_FILE=/run/secrets/<secret_name> \
- -e POSTGRES_PASSWORD_FILE=/run/secrets/<secret_name> \
+ --link some-postgresql:postgresql \
Review Comment:
`--link` is deprecated according to this [Legacy Container
links](https://docs.docker.com/network/links/) but it's still working. No sure
how many people are using it.
If it should be removed, it should be removed in another issue/PR.
The `--link some-postgresql:postgresql ` means that environment variables
for the ports are generated using the `<name>_PORT_<port>_<protocol>` format
where `<name>` is the name of the last part of the link (`postgresql`) for us
but `postgres` before my change.
We can add compatibility for older environment variable names but at some
point it will be removed and will break for some people, maybe it's "easier" to
add it in compatibility change when the image will be released so people can
see it explicitely. They'll need to do this change at some point if we want to
align everything.
If we don't want to align everything, we must solve the otherway and rename
the few environment variables using `POSTGRESQL_*` to `POSTGRES_*` because it
doesn't make sense to have some using one syntax and other using the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
