mike-jumper commented on code in PR #717:
URL: https://github.com/apache/guacamole-client/pull/717#discussion_r854736107
##########
guacamole-docker/README.md:
##########
@@ -55,31 +55,31 @@ Deploying Guacamole with PostgreSQL authentication
--------------------------------------------------
docker run --name some-guacamole --link some-guacd:guacd \
- --link some-postgres:postgres \
- -e POSTGRES_DATABASE=guacamole_db \
- -e POSTGRES_USER=guacamole_user \
- -e POSTGRES_PASSWORD=some_password \
- -e POSTGRES_DATABASE_FILE=/run/secrets/<secret_name> \
- -e POSTGRES_USER_FILE=/run/secrets/<secret_name> \
- -e POSTGRES_PASSWORD_FILE=/run/secrets/<secret_name> \
+ --link some-postgresql:postgresql \
Review Comment:
Originally, the `POSTGRES_*` prefix was chosen despite the property names to
match the similar environment variables used by Docker's official `postgres`
container. Aligning things universally with properties makes sense and would
allow some automation for setting properties (via the environment properties
feature).
There will be pain for anyone using the old variables. If we do this, it's
probably worth adding compatibility for the `POSTGRES_` prefix and `--postgres`
option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
