jbpaux commented on code in PR #717:
URL: https://github.com/apache/guacamole-client/pull/717#discussion_r859576021
##########
guacamole-docker/README.md:
##########
@@ -55,31 +55,31 @@ Deploying Guacamole with PostgreSQL authentication
--------------------------------------------------
docker run --name some-guacamole --link some-guacd:guacd \
- --link some-postgres:postgres \
- -e POSTGRES_DATABASE=guacamole_db \
- -e POSTGRES_USER=guacamole_user \
- -e POSTGRES_PASSWORD=some_password \
- -e POSTGRES_DATABASE_FILE=/run/secrets/<secret_name> \
- -e POSTGRES_USER_FILE=/run/secrets/<secret_name> \
- -e POSTGRES_PASSWORD_FILE=/run/secrets/<secret_name> \
+ --link some-postgresql:postgresql \
Review Comment:
Yes `--link` is deprecated but can still be used. If you want to remove them
I guess it will be done in another issue/PR. See more on [Legacy container
links](https://docs.docker.com/network/links/). The environment variables
related to the link are generated from the last part of the `--link
mypostgres:postgres` which results in `<name>_PORT_<port>_<protocol>` variable
and `<name>_NAME` variable. So in our case `postgres`. In the PR I've renamed
it too so it's consistent with other variable names but it's just to make it
prettier.
For the other variables, renaming them from `POSTGRES_` to `POSTGRESSQL_`
will of course break current deployment. If needed we can have both but I can
imagine it will be removed one day and it will cause the same issue. It would
maybe be easier to point it in the release notes that the variables changed
their names and need to be changed in docker compose etc.
How do you want to move forward on it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
