[ 
https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533412#comment-16533412
 ] 

ASF GitHub Bot commented on HTTPCORE-484:
-----------------------------------------

Github user ok2c commented on the issue:

    https://github.com/apache/httpcomponents-core/pull/67
  
    @xiaohu-zhang This is a large chunk of code that comes directly from 
another project. The code is ASLv2 licensed and based on published academic 
research. I personally do not see a problem taking this code but I would like 
to adjust it a bit more to our coding conventions. It may take me a few days or 
more. Please bear with me.


> check timeout could use TimeWheel algorithm
> -------------------------------------------
>
>                 Key: HTTPCORE-484
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-484
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore NIO
>    Affects Versions: 4.4.6
>            Reporter: silver9886
>            Priority: Major
>             Fix For: 5.0
>
>
> check time out every this.selectTimeout,and had to iterator all the 
> SelectionKeys.
> it is not efficient nor accurate when their is a lot of SelectionKeys.
> I suggest use the TimeWheel algorithm when check the channel time out just
> as netty do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to