[
https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542705#comment-16542705
]
ASF GitHub Bot commented on HTTPCORE-484:
-----------------------------------------
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
1. How come? That basically means that a read or write event can get
triggered by an I/O reactor thread concurrently with a timeout event triggered
by the time-wheel thread making it necessary to synchronize **_all_** methods
of the `IOEventHandler` interface. This breaks current `IOEventHandler`
contract and possibly negates all the performance gains from your changes
2. This is theory and it looks promising. But I still would like to see if
it actually produces any performance in real life scenarios, especially in
situations when _every_ channel sets a socket timeout.
I do not think I can accept the change-set in its current state. It can be
accepted if we can solve the concurrency issue and get some empirical evidence
of performance improvement.
Are you at the dev@hc.apache.org list? If not, please subscribe and let us
discuss further steps on the dev list.
> check timeout could use TimeWheel algorithm
> -------------------------------------------
>
> Key: HTTPCORE-484
> URL: https://issues.apache.org/jira/browse/HTTPCORE-484
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 4.4.6
> Reporter: silver9886
> Assignee: Oleg Kalnichevski
> Priority: Major
> Fix For: 5.0-beta3
>
>
> check time out every this.selectTimeout,and had to iterator all the
> SelectionKeys.
> it is not efficient nor accurate when their is a lot of SelectionKeys.
> I suggest use the TimeWheel algorithm when check the channel time out just
> as netty do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
