[
https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538157#comment-16538157
]
ASF GitHub Bot commented on HTTPCORE-484:
-----------------------------------------
Github user ok2c commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
@xiaohu-zhang This is a much bigger change that I have initially
anticipated. It will take me a while to absorb it. First off, I do not think
HttpCore should expose any of those classes in its public APIs. I moved the
classes to the `org.apache.hc.core5.reactor` package and I intend to make them
all package private. Those people who need it as a generic, re-usable
time-wheel implementation should be using Netty instead. I am also trying to
reduce the amount of code and classes that we would end up maintaining.
I also dislike `HashedWheelTimer` instance being static.
My code can be found here:
https://github.com/ok2c/httpcore/tree/timewheel
It is still in very early stages.
> check timeout could use TimeWheel algorithm
> -------------------------------------------
>
> Key: HTTPCORE-484
> URL: https://issues.apache.org/jira/browse/HTTPCORE-484
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 4.4.6
> Reporter: silver9886
> Assignee: Oleg Kalnichevski
> Priority: Major
> Fix For: 5.0-beta3
>
>
> check time out every this.selectTimeout,and had to iterator all the
> SelectionKeys.
> it is not efficient nor accurate when their is a lot of SelectionKeys.
> I suggest use the TimeWheel algorithm when check the channel time out just
> as netty do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
