[
https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539958#comment-16539958
]
ASF GitHub Bot commented on HTTPCORE-484:
-----------------------------------------
Github user xiaohu-zhang commented on the issue:
https://github.com/apache/httpcomponents-core/pull/67
1. testTimeoutInSSecond method in class TestHashedWheelTimer should rename
to testTimeoutInSecond ,I dont have permission to push to your branch.
2.why delete
if (isWindows()) {
- sleepTimeMs = sleepTimeMs / 10 * 10;
- }
in HashedWheelTimer class. the comment is clearly said why use this code
blocks in netty.
3. I agree with you set package private. I dont like HashedWheelTimer being
static too.Because
HashedWheelTimer class is used only in framework,I think we could change
HashedWheelTimer to be
singleton
> check timeout could use TimeWheel algorithm
> -------------------------------------------
>
> Key: HTTPCORE-484
> URL: https://issues.apache.org/jira/browse/HTTPCORE-484
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore NIO
> Affects Versions: 4.4.6
> Reporter: silver9886
> Assignee: Oleg Kalnichevski
> Priority: Major
> Fix For: 5.0-beta3
>
>
> check time out every this.selectTimeout,and had to iterator all the
> SelectionKeys.
> it is not efficient nor accurate when their is a lot of SelectionKeys.
> I suggest use the TimeWheel algorithm when check the channel time out just
> as netty do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
