[ 
https://issues.apache.org/jira/browse/HTTPCORE-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541704#comment-16541704
 ] 

ASF GitHub Bot commented on HTTPCORE-484:
-----------------------------------------

Github user ok2c commented on the issue:

    https://github.com/apache/httpcomponents-core/pull/67
  
    @xiaohu-zhang I have spent more time looking at the proposed change-set. 
    1. Do I understand it correctly that with this patch all 
`IOEventHandler#timeout` events will be executed by a separate thread and will 
require synchronization for all `IOEventHandler` implementations?
    2. Can you quantify performance improvement with the proposed change-set? 
What kind of performance improvement can we expect?  


> check timeout could use TimeWheel algorithm
> -------------------------------------------
>
>                 Key: HTTPCORE-484
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-484
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore NIO
>    Affects Versions: 4.4.6
>            Reporter: silver9886
>            Assignee: Oleg Kalnichevski
>            Priority: Major
>             Fix For: 5.0-beta3
>
>
> check time out every this.selectTimeout,and had to iterator all the 
> SelectionKeys.
> it is not efficient nor accurate when their is a lot of SelectionKeys.
> I suggest use the TimeWheel algorithm when check the channel time out just
> as netty do.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to