On Fri, Oct 12, 2018 at 11:20 AM Gary Gregory <[email protected]> wrote:
> Once this PR is hopefully accepted, I'd like to add and > use org.apache.hc.core5.concurrent.BasicFuture.get(Timeout). > Hm, BasicFuture.get(Timeout) probably does not make sense since java.util.concurrent.Future does not define such a get() method; unless we want to create our own interface that extends Future to add a get(Timeout). Any thoughts on that one? Gary > Gary > > On Fri, Oct 12, 2018 at 10:28 AM garydgregory <[email protected]> wrote: > >> GitHub user garydgregory opened a pull request: >> >> https://github.com/apache/httpcomponents-core/pull/90 >> >> Define a timeout exception more precisely. >> >> Create and use a subclass of java.util.concurrent.TimeoutException >> called TimeoutValueException to precisely define a timeout exception. >> >> You can merge this pull request into a Git repository by running: >> >> $ git pull https://github.com/garydgregory/httpcore >> timeout-value-exception >> >> Alternatively you can review and apply these changes as the patch at: >> >> https://github.com/apache/httpcomponents-core/pull/90.patch >> >> To close this pull request, make a commit to your master/trunk branch >> with (at least) the following in the commit message: >> >> This closes #90 >> >> ---- >> commit 64d3b53437342a1cdeb72df08368392406e37098 >> Author: Gary Gregory <ggregory@...> >> Date: 2018-10-12T16:26:14Z >> >> Create a subclass of java.util.concurrent.TimeoutException called >> TimeoutValueException to precisely define a timeout exception. >> >> ---- >> >> >> --- >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
