Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/90#discussion_r224963982
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/concurrent/BasicFuture.java ---
@@ -94,7 +95,7 @@ public synchronized T get(final long timeout, final
TimeUnit unit)
if (this.completed) {
return getResult();
} else if (waitTime <= 0) {
- throw new TimeoutException();
+ throw TimeoutValueException.ofMillis(msecs, msecs +
Math.abs(waitTime));
--- End diff --
@ok2c ,
Thank you for your comment.
What is the "timeout value"? Is it the boundary of time above which the
timeout occurs or is it the actual elapsed time? To both avoid this confusion
and to be as precise with the message as possible, both values are given:
- The "deadline" in the message is the the boundary of time above which the
timeout occurs.
- The "actual" in the message is the actual elapsed time.
Does that clarify things for you?
Gary
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
