Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/90#discussion_r224967357
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/concurrent/BasicFuture.java ---
@@ -94,7 +95,7 @@ public synchronized T get(final long timeout, final
TimeUnit unit)
if (this.completed) {
return getResult();
} else if (waitTime <= 0) {
- throw new TimeoutException();
+ throw TimeoutValueException.ofMillis(msecs, msecs +
Math.abs(waitTime));
--- End diff --
@garydgregory This is clearly not how I interpret this piece of code.
```
final long now = System.currentTimeMillis();
if (now > deadline) {
leaseRequest.failed(TimeoutValueException.ofMillis(deadline, now));
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
