Github user ok2c commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/90#discussion_r224965432
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/concurrent/BasicFuture.java ---
@@ -94,7 +95,7 @@ public synchronized T get(final long timeout, final
TimeUnit unit)
if (this.completed) {
return getResult();
} else if (waitTime <= 0) {
- throw new TimeoutException();
+ throw TimeoutValueException.ofMillis(msecs, msecs +
Math.abs(waitTime));
--- End diff --
@garydgregory To me it is Is it the _"boundary of time above which the
timeout occurs"_. Yes, it does clarify but i personally do not find this
information useful. The initial timeout value given by the user, say 30
seconds, might be marginally useful, but the number of milliseconds that have
elapsed since midnight, January 1, 1970, when the operation timed out is not.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
