Github user garydgregory commented on a diff in the pull request:
https://github.com/apache/httpcomponents-core/pull/90#discussion_r225006254
--- Diff:
httpcore5/src/main/java/org/apache/hc/core5/concurrent/BasicFuture.java ---
@@ -94,7 +95,7 @@ public synchronized T get(final long timeout, final
TimeUnit unit)
if (this.completed) {
return getResult();
} else if (waitTime <= 0) {
- throw new TimeoutException();
+ throw TimeoutValueException.ofMillis(msecs, msecs +
Math.abs(waitTime));
--- End diff --
Yes, for that call site, you are correct, my implementation is incorrect, I
will adjust...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
