> On June 10, 2016, 12:24 a.m., Hari Sankar Sivarama Subramaniyan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java, > > line 379 > > <https://reviews.apache.org/r/48520/diff/1/?file=1414178#file1414178line379> > > > > nit: is it possible to make allDirs as SynchronizedSet so that someone > > doesnt misuse this in future.
It is already synchronized? see Set<Path> dirSet = Collections.synchronizedSet(new HashSet<Path>()); - pengcheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/#review136931 ----------------------------------------------------------- On June 9, 2016, 11:16 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48520/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 11:16 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-13984 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 10fa561 > > Diff: https://reviews.apache.org/r/48520/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
