----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48520/#review136987 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 383) <https://reviews.apache.org/r/48520/#comment202104> May be we can create HIVE_LIST_FILES_THREAD_COUNT which can have a min thread of 1. So that way, we dont need to maintain serial codepath. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 384) <https://reviews.apache.org/r/48520/#comment202102> This can be passed from previous function to avoid creating executor pool, in case of recursion at the end of this method. ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java (line 408) <https://reviews.apache.org/r/48520/#comment202103> Same as above. If executor can be passed from previous method, shutdown can be avoided here and can be moved to getAllLeafDirs(Path basePath, Set<Path> allDirs) - Rajesh Balamohan On June 10, 2016, 11:58 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48520/ > ----------------------------------------------------------- > > (Updated June 10, 2016, 11:58 p.m.) > > > Review request for hive and Hari Sankar Sivarama Subramaniyan. > > > Repository: hive-git > > > Description > ------- > > HIVE-13984 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMetaStoreChecker.java > 10fa561 > > Diff: https://reviews.apache.org/r/48520/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
