----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review195897 -----------------------------------------------------------
Thanks a lot Peter for the patch! It looks good to me, I only have few questions and nits. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java Lines 409 (patched) <https://reviews.apache.org/r/65210/#comment275246> After dropping the functions, it could be verified if they are really deleted. Like doing a get or list for the deleted function and check if it doesn't exist any more. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java Lines 455 (patched) <https://reviews.apache.org/r/65210/#comment275247> What happens if the filter is empty? Is the result going to be empty or contain all functions? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java Lines 544 (patched) <https://reviews.apache.org/r/65210/#comment275248> What do you mean by changing only the class won't cause exception? In which cases will you get exception during altering a function? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java Lines 605 (patched) <https://reviews.apache.org/r/65210/#comment275250> Calling alterFunction with null newFunction migh be also a test case. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java Lines 628 (patched) <https://reviews.apache.org/r/65210/#comment275249> I guess the NullPointerException here is a typo. In the catch there is InvalidObjectException. - Marta Kuczora On Jan. 18, 2018, 11:37 a.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65210/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 11:37 a.m.) > > > Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang > Karajgaonkar. > > > Bugs: HIVE-18480 > https://issues.apache.org/jira/browse/HIVE-18480 > > > Repository: hive-git > > > Description > ------- > > The test tries to go throught all af the function related tests and test with > various imputs, so not only the happy path, but the edge cases are covered too > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65210/diff/1/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Peter Vary > >
