> On Jan. 22, 2018, 1:41 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 409 (patched) > > <https://reviews.apache.org/r/65210/diff/1/?file=1941480#file1941480line409> > > > > After dropping the functions, it could be verified if they are really > > deleted. Like doing a get or list for the deleted function and check if it > > doesn't exist any more.
Done, thanks, this caught an error in the test :) > On Jan. 22, 2018, 1:41 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 455 (patched) > > <https://reviews.apache.org/r/65210/diff/1/?file=1941480#file1941480line455> > > > > What happens if the filter is empty? Is the result going to be empty or > > contain all functions? Added a test for this as well. Thanks! > On Jan. 22, 2018, 1:41 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 544 (patched) > > <https://reviews.apache.org/r/65210/diff/1/?file=1941480#file1941480line544> > > > > What do you mean by changing only the class won't cause exception? In > > which cases will you get exception during altering a function? Rewritten the comment :) I hope this is better now :) > On Jan. 22, 2018, 1:41 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 605 (patched) > > <https://reviews.apache.org/r/65210/diff/1/?file=1941480#file1941480line605> > > > > Calling alterFunction with null newFunction migh be also a test case. Done. Thanks! - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review195897 ----------------------------------------------------------- On Jan. 22, 2018, 2:33 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65210/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2018, 2:33 p.m.) > > > Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang > Karajgaonkar. > > > Bugs: HIVE-18480 > https://issues.apache.org/jira/browse/HIVE-18480 > > > Repository: hive-git > > > Description > ------- > > The test tries to go throught all af the function related tests and test with > various imputs, so not only the happy path, but the edge cases are covered too > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65210/diff/2/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Peter Vary > >
