> On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 236 (patched) > > <https://reviews.apache.org/r/65210/diff/3/?file=1944543#file1944543line236> > > > > Should we be filing JIRAs for the TODO items? > > Peter Vary wrote: > I have to check the root causes of the issues, and file the jiras > accordingly. > Most probably several of the TODOs will be solved with a 1 or 2 changes. > After the RCA I will file the jiras under this umbrela jira. > So if you do not mind, I will do it later
Sounds good to me. - Sahil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196065 ----------------------------------------------------------- On Jan. 24, 2018, 10:52 a.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65210/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 10:52 a.m.) > > > Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang > Karajgaonkar. > > > Bugs: HIVE-18480 > https://issues.apache.org/jira/browse/HIVE-18480 > > > Repository: hive-git > > > Description > ------- > > The test tries to go throught all af the function related tests and test with > various imputs, so not only the happy path, but the edge cases are covered too > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65210/diff/4/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Peter Vary > >
