----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196065 -----------------------------------------------------------
A few comments, in general the tests look very thorough. Nice work! standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java Lines 236 (patched) <https://reviews.apache.org/r/65210/#comment275585> Should we be filing JIRAs for the TODO items? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java Lines 246 (patched) <https://reviews.apache.org/r/65210/#comment275586> shouldn't this test have an assert somewhere? is it possible to used the `expected` parameter of `@Test` with multiple exceptions? Same with the tests below. I think all unit tests should have an Assert, even if its asserting that a specific exception is being thrown. It helps define the contract for the test. - Sahil Takiar On Jan. 23, 2018, 4:47 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65210/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2018, 4:47 p.m.) > > > Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang > Karajgaonkar. > > > Bugs: HIVE-18480 > https://issues.apache.org/jira/browse/HIVE-18480 > > > Repository: hive-git > > > Description > ------- > > The test tries to go throught all af the function related tests and test with > various imputs, so not only the happy path, but the edge cases are covered too > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65210/diff/3/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Peter Vary > >
