> On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > A few comments, in general the tests look very thorough. Nice work!
Thanks for the review Sahil! > On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 236 (patched) > > <https://reviews.apache.org/r/65210/diff/3/?file=1944543#file1944543line236> > > > > Should we be filing JIRAs for the TODO items? I have to check the root causes of the issues, and file the jiras accordingly. Most probably several of the TODOs will be solved with a 1 or 2 changes. After the RCA I will file the jiras under this umbrela jira. So if you do not mind, I will do it later > On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 246 (patched) > > <https://reviews.apache.org/r/65210/diff/3/?file=1944543#file1944543line246> > > > > shouldn't this test have an assert somewhere? is it possible to used > > the `expected` parameter of `@Test` with multiple exceptions? > > > > Same with the tests below. I think all unit tests should have an > > Assert, even if its asserting that a specific exception is being thrown. It > > helps define the contract for the test. Yeah, good catch - added the needed asserts. I did not find a way to test for multiple exceptions with the expected paramter. If you find, I would be happy to use, but did not spend too much time on it, since I expect that these multiple chatches will be removed as soon as we fix the TODO items. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review196065 ----------------------------------------------------------- On Jan. 24, 2018, 10:52 a.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65210/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 10:52 a.m.) > > > Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang > Karajgaonkar. > > > Bugs: HIVE-18480 > https://issues.apache.org/jira/browse/HIVE-18480 > > > Repository: hive-git > > > Description > ------- > > The test tries to go throught all af the function related tests and test with > various imputs, so not only the happy path, but the edge cases are covered too > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65210/diff/4/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Peter Vary > >
