Henry Robinson has posted comments on this change. Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI ......................................................................
Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/2625/1/be/src/service/impala-server-callbacks.cc File be/src/service/impala-server-callbacks.cc: Line 303: num_waiting_queries++; single line, prefer pre-increment http://gerrit.cloudera.org:8080/#/c/2625/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 1599: blank line can be removed http://gerrit.cloudera.org:8080/#/c/2625/1/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 610: eos prefer "all_rows_returned" http://gerrit.cloudera.org:8080/#/c/2625/1/www/queries.tmpl File www/queries.tmpl: Line 60: {{num_waiting_queries}} waiting on client this makes it sound like the queries are waiting on *some* client input (which would include fetching some more rows). These are finished queries that are waiting for the client to close them. Line 61: <sup><a href='#' data-toggle="tooltip" title="{{waiting-tooltip}}">[?]</a></sup> Better just to inline the tooltip text here. Line 77: <th>Action</th> It would be good to have a measure of the time a query has been waiting for since the last action. Can you see if that's already recorded somewhere? The ClientFetchWaitTimer isn't quite what we want, but is close. -- To view, visit http://gerrit.cloudera.org:8080/2625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
