Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/2625/3/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 610: all_rows_returned we typically use "eos" to indicate this http://gerrit.cloudera.org:8080/#/c/2625/3/www/queries.tmpl File www/queries.tmpl: Line 79: in_flight_queries Can you rename this to something like #waiting_queries or does this need to stay as in_flight_queries for the json endpoint to work? I wonder if there's a way to leave a comment in the lua without having it outputted in the resulting html. Line 96: in_flight_queries Depending on what we do on l79 then I think this would be /waiting_queries -- To view, visit http://gerrit.cloudera.org:8080/2625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
