Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI ......................................................................
Patch Set 1: (3 comments) A few comments on revision #1 to follow up on existing comments. I'm also going to post a review for revision #3 in a few minutes. http://gerrit.cloudera.org:8080/#/c/2625/1/www/queries.tmpl File www/queries.tmpl: Line 22: in flight How about changing in flight to "currently executing"? Can we add a [?] tooltip here too to indicate that the results are not yet ready to be fetched by the client? Line 60: {{num_waiting_queries}} waiting on client > Done or "ready for client action"? Line 77: <th>Action</th> > It looks like last_active_time is updated either when a query first gets ex As we just discussed in person, I also think that behavior sounds OK. I think most users probably aren't aware about actions like GetStatus that may be performed by a client, and that just showing the last time the rows were fetched is very helpful. In fact, if a client happened to be sometimes polling GetStatus (i dont know if any do but it's possible), then using the time since the last GetStatus could hide queries that are sitting around. We can change this later if we find this to be insufficient. -- To view, visit http://gerrit.cloudera.org:8080/2625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
