Henry Robinson has posted comments on this change.

Change subject: IMPALA-2198: Differentiate queries in exceptional states in web 
UI
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2625/3/be/src/service/impala-server.h
File be/src/service/impala-server.h:

Line 610: all_rows_returned
> we typically use "eos" to indicate this
FWIW I asked Thomas to change this from 'eos', which I think isn't quite as 
clear in this context. Happy with whatever you agree on though.


-- 
To view, visit http://gerrit.cloudera.org:8080/2625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-HasComments: Yes

Reply via email to