Henry Robinson has posted comments on this change.

Change subject: IMPALA-2198: Differentiate queries in exceptional states in web 
UI
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2625/1/www/queries.tmpl
File www/queries.tmpl:

Line 60:   {{num_waiting_queries}} waiting on client
> I'm open to suggestions of the clearest thing to put here. It seems weird t
waiting to be closed is better than waiting on client, so go ahead with that 
change.


Line 61:   <sup><a href='#' data-toggle="tooltip" 
title="{{waiting-tooltip}}">[?]</a></sup>
> I hadn't done this because I can't figure out any way to wrap an html strin
Not sure, and it seems hard to Google. Leave it like this for now and we'll see 
if we can find a better solution.


Line 77:     <th>Action</th>
> The closest thing we already have that I can find would be using the differ
The last time the client contacted the server for this query is probably ok, if 
that's what last_active_time represents. That time will usually be relatively 
large compared to the time taken to do the last bit of server-side processing.

I think the behaviour with idle-query-timeout sounds reasonable - we're looking 
for a measure of how idle the client has gone.


-- 
To view, visit http://gerrit.cloudera.org:8080/2625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-HasComments: Yes

Reply via email to