Taras Bobrovytsky has posted comments on this change. Change subject: Add Breakpad minidump collection script ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/2997/4/bin/collect_minidumps.py File bin/collect_minidumps.py: Line 75: files with modified date not in the eligible range. It is assumed that source_dir > I think "regular files" might describe it best. I like the way it's rewritten in the latest patch. Line 179: parser.add_option('--output_file_path', default='/tmp/minidump_package.tar.gz', > I agree with Taras in that I wouldn't store it in the same folder as the sc Done http://gerrit.cloudera.org:8080/#/c/2997/4/bin/generate_minidump_collection_testdata.py File bin/generate_minidump_collection_testdata.py: Line 122: accoplish > nit: accomplish Done -- To view, visit http://gerrit.cloudera.org:8080/2997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85b3643133e28eca07507ac2a79acbf73128456f Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
