Lars Volker has posted comments on this change. Change subject: Add Breakpad minidump collection script ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/2997/5/bin/collect_minidumps.py File bin/collect_minidumps.py: Line 20: # --role_name=statestored --max_output_size=50000000 --end_time=1463033495 Nit: One line has a \, the other doesn't http://gerrit.cloudera.org:8080/#/c/2997/5/bin/generate_minidump_collection_testdata.py File bin/generate_minidump_collection_testdata.py: Line 89: raise wouldn't this have to be "raise e"? -- To view, visit http://gerrit.cloudera.org:8080/2997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85b3643133e28eca07507ac2a79acbf73128456f Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
