Lars Volker has posted comments on this change. Change subject: Add Breakpad minidump collection script ......................................................................
Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/2997/4/bin/collect_minidumps.py File bin/collect_minidumps.py: Line 61: num_files = num_files or len(self.file_list) > Do we need to worry about the case if the directory somehow has hundreds of For breakpad we don't, the default number of minidump files is 9 per daemon and they're small. Permissions are set to 600, so there we (or CM) actually might have to worry. Can you check with Ankur? Line 75: files with modified date not in the eligible range. It is assumed that source_dir > Done I think "regular files" might describe it best. Line 179: parser.add_option('--output_file_path', default='/tmp/minidump_package.tar.gz', > Done. I guess that makes sense, but I think it's also not necessarily a goo I agree with Taras in that I wouldn't store it in the same folder as the script. Can we just remove the default and make it a required parameter? http://gerrit.cloudera.org:8080/#/c/2997/4/bin/generate_minidump_collection_testdata.py File bin/generate_minidump_collection_testdata.py: Line 122: accoplish nit: accomplish -- To view, visit http://gerrit.cloudera.org:8080/2997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85b3643133e28eca07507ac2a79acbf73128456f Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
