Lars Volker has posted comments on this change. Change subject: Add Breakpad minidump collection script ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2997/3/bin/collect_minidumps.py File bin/collect_minidumps.py: Line 158: result > Really? I was under the impression that the path is completely encoded in t Yes, really. I think we did it to follow the approach of logfiles, where we specify the same directory for each daemon and then the daemons create files there, which contain the daemon name. In this case the file names are created by breakpad, so we create folders to separate the daemons from each other. Thus the admin cannot accidentally make them write to the same folder. In hindsight that seems to cause more confusion than I had thought. Tbh, I don't really know how to change it now, except in a concerted effort between Ankur, you, and me. Do you think we should try to change it? Line 181: file_archiver = FileArchiver(source_dir=minidump_dir, > I think it's much more readable the way it is. I think this type of formatt Fine with me, I actually like it better and wasn't sure how our python style looks (so I assumed it follows the C++ and Java code where applicable). -- To view, visit http://gerrit.cloudera.org:8080/2997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85b3643133e28eca07507ac2a79acbf73128456f Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
