Michael Brown has posted comments on this change. Change subject: Add Breakpad minidump collection script ......................................................................
Patch Set 6: (8 comments) No big objections, just a few nits here and there. Most of them are typos. http://gerrit.cloudera.org:8080/#/c/2997/6//COMMIT_MSG Commit Message: Line 7: Add Breakpad minidump collection script Nit: bug number Line 10: collect_minidumps.py - generates a compressed tarball that containing s/containing/contains/ ? Line 12: generate_minidump_collection_testdata.py - generates testdate for the s/testdate/testdata/ http://gerrit.cloudera.org:8080/#/c/2997/6/bin/collect_minidumps.py File bin/collect_minidumps.py: Line 160: if not os.path.isdir(result): : sys.exit(0) Why the exit with success status here? http://gerrit.cloudera.org:8080/#/c/2997/6/bin/generate_minidump_collection_testdata.py File bin/generate_minidump_collection_testdata.py: Line 15: # This script generates testdate for collect_minidumps.py. 3 files with startuped "with startuped" -- I can't figure out what that means. Line 23: Alternatiely Alternatively Line 25: repeaded repeated Line 120: # We the files We want? -- To view, visit http://gerrit.cloudera.org:8080/2997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85b3643133e28eca07507ac2a79acbf73128456f Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Ishaan Joshi <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes
