Jim Apple has posted comments on this change. Change subject: IMPALA-2878: Remove unused function and duplicate codes. ......................................................................
Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/3244/5/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: Line 823: memcpy(reinterpret_cast<void*>(result.ptr), encoded_str.c_str(), encoded_str.size()); I did not mean to please avoid the use of that particular copying function. I meant to please avoid the overhead of doing a copy. Line 840: << ", which is not a multiple of 4."; fix indent Line 859: << "; actual output length " << out_len; fix indent http://gerrit.cloudera.org:8080/#/c/3244/5/be/src/util/url-coding.h File be/src/util/url-coding.h: Line 40: enum class EncodeStatus { ENCODE_OK, INVALID_LEN, ENCODE_FAIL }; How about "Base64EncodeStatus"? -- To view, visit http://gerrit.cloudera.org:8080/3244 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c46023754139ee7eeceeb3b77a3be5d156d608 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Yuanhao Luo <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Yuanhao Luo <[email protected]> Gerrit-HasComments: Yes
