Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/3315
Change subject: IMPALA-3670,IMPALA-3669: fix sorter buffer mgmt bugs and tests ...................................................................... IMPALA-3670,IMPALA-3669: fix sorter buffer mgmt bugs and tests Fix a couple of resource management bugs in the sorter. Add a sort test that consumes the entire output of the sorter, executing with various amounts of memory. This test reproduced one of the sorter bugs, where var-len blocks were not always attached to the output batch. Also make test_scratch_disk.py more deterministic, by using max_block_mgr_memory, which doesn't include scanner memory. The fixed test_scratch_disk.py exercises the other sorter bugs that occurs when scratch cannot be written. Testing: Added a test that does a sort with various memory limits and consumes the whole output of the sorter (we have many tests of sorts with limits but limited coverage of sorts without limits). Ran an exhaustive test run before posting for review. Change-Id: Ia1a0ddffa0a5b157ab86a376b7b7360a923698d6 --- M be/src/runtime/sorter.cc M tests/custom_cluster/test_scratch_disk.py M tests/query_test/test_sort.py 3 files changed, 45 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/15/3315/1 -- To view, visit http://gerrit.cloudera.org:8080/3315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia1a0ddffa0a5b157ab86a376b7b7360a923698d6 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]>
