Tim Armstrong has posted comments on this change. Change subject: IMPALA-3670: fix sorter buffer mgmt bugs ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3315/3/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 816: if (!HasVarLenBlocks()) DCHECK(!CONVERT_OFFSET_TO_PTR); > I think this is clearer/simpler if these two DCHECKs are reduced to: Done -- To view, visit http://gerrit.cloudera.org:8080/3315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1a0ddffa0a5b157ab86a376b7b7360a923698d6 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
