Tim Armstrong has posted comments on this change. Change subject: IMPALA-3670,IMPALA-3669: fix sorter buffer mgmt bugs and tests ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3315/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 894: // Also attach the var-len blocks at eos, since we no longer need them. > why was this needed given block at line 867? That's the false assumption that lead to the bug. Consider the case when we have a single in-memory run, and we sorted it in-place. Then the var-len data is out-of-order relative to the fixed-len data. Any fixed-len tuple can reference any var-len block, so we can't delete var-len blocks as we go. In that case CONVERT_OFFSET_TO_PTR is (correctly) false and line 867 is (correctly) never executed. -- To view, visit http://gerrit.cloudera.org:8080/3315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1a0ddffa0a5b157ab86a376b7b7360a923698d6 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
