Tim Armstrong has posted comments on this change. Change subject: IMPALA-3670: fix sorter buffer mgmt bugs ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3315/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 894: // Also attach the var-len blocks at eos, since we no longer need them. > let's add a brief comment explaining that. We already have a DCHECK for CONVERT_OFFSET_TO_PTR and is_pinned_ up the top, so there was some dead code there. Cleaned up the code above. Line 896: for (int i = 0; i < var_len_blocks_.size(); ++i) { Cleaned up this loop a little and added a DCHECK. -- To view, visit http://gerrit.cloudera.org:8080/3315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1a0ddffa0a5b157ab86a376b7b7360a923698d6 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
