Dan Hecht has posted comments on this change. Change subject: IMPALA-3670,IMPALA-3669: fix sorter buffer mgmt bugs and tests ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3315/1/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: Line 894: // Also attach the var-len blocks at eos, since we no longer need them. > That's the false assumption that lead to the bug. let's add a brief comment explaining that. What's the current relationship between CONVER_OFFSET_TO_PTR and is_pinned_ now? Is that something we should/could tighten up? e.g. is (CONVERT_OFFSET_TO_PTR && is_pinned_) still possible? If so, won't this code pass NULL to AddBlock() in that case? If not, we should clarify that invariant and clean up line 866. -- To view, visit http://gerrit.cloudera.org:8080/3315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1a0ddffa0a5b157ab86a376b7b7360a923698d6 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
