Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1671: Print time and link to coordinator web UI once query is submitted in shell ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3507/2/shell/impala_shell.py File shell/impala_shell.py: PS2, Line 676: if version > Curious -- is there ever a time when we'd get successfully connect here (i. Good catch. The way it's setup it looks like that case could never happen. Which means I can get rid of the 'if' check. PS2, Line 858: try > This try block is getting quite long. Long try blocks followed by several e I agree that this could use some refactoring. However, for the most part, most of the code executed inside the try block uses the 'imp_client' which can hit an RPCException, DisconnectedException or a socket.error. I think a QueryStateException can only be hit during execute_query(). I could open another JIRA for this if necessary. Line 862: result = self.imp_client.ping_impala_service() > So this is a micro-optimization, but in general, I thinks it's cleaner to u Thanks, it looks a lot cleaner now. Done. -- To view, visit http://gerrit.cloudera.org:8080/3507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I704eb64546e27c367830120241311fea6091266b Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
