Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1671: Print time and link to coordinator web UI once query is submitted in shell ......................................................................
Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/3507/4/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: PS4, Line 503: return_val.hostname = FLAGS_hostname; : return_val.webserver_port = FLAGS_webserver_port; > use ExecEnv::Instance()->webserver()->http_address(); Good idea. I've added a BuildUrlString() function in webserver.cc to aid with this. PS4, Line 505: std::time(0) > why not local time? I thought it's just cheaper to return an epoch because it's an integer versus a string, and let the shell deal with converting it. http://gerrit.cloudera.org:8080/#/c/3507/4/shell/impala_client.py File shell/impala_client.py: Line 232: result = self.imp_service.PingImpalaService() > use self.ping_impala_service() for consistency here. Done http://gerrit.cloudera.org:8080/#/c/3507/2/shell/impala_shell.py File shell/impala_shell.py: PS2, Line 858: try > I think that's probably an acceptable solution. Perhaps reference the JIRA Yup, I've opened IMPALA-3814 and also added it as a comment here. http://gerrit.cloudera.org:8080/#/c/3507/3/shell/impala_shell.py File shell/impala_shell.py: PS3, Line 870: //%s:%s > IMO, its better to print the query URL here, else on a busy cluster, we nee Yes I thought about that but there is a delay before the web UI can print in this case. But I think it should be fine, because we wait for results only after printing the web UI. Done. PS3, Line 870: http > This can be https too, you might want to check if ssl is enabled and based I did this check in the C++ side now and return the entire webserver URL along with the protocol. -- To view, visit http://gerrit.cloudera.org:8080/3507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I704eb64546e27c367830120241311fea6091266b Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
