Henry Robinson has posted comments on this change. Change subject: IMPALA-1671: Print time and link to coordinator web UI once query is submitted in shell ......................................................................
Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3507/4/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: PS4, Line 503: return_val.hostname = FLAGS_hostname; : return_val.webserver_port = FLAGS_webserver_port; use ExecEnv::Instance()->webserver()->http_address(); Even better, consider a method to return the base URL of the server as a string (in Webserver) that can handle http / https etc. PS4, Line 505: std::time(0) why not local time? http://gerrit.cloudera.org:8080/#/c/3507/4/shell/impala_client.py File shell/impala_client.py: Line 232: result = self.imp_service.PingImpalaService() use self.ping_impala_service() for consistency here. -- To view, visit http://gerrit.cloudera.org:8080/3507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I704eb64546e27c367830120241311fea6091266b Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
