Henry Robinson has posted comments on this change. Change subject: IMPALA-1671: Print time and link to coordinator web UI once query is submitted in shell ......................................................................
Patch Set 5: (4 comments) Looks pretty close. Can you add a shell test to check that the right things are printed? http://gerrit.cloudera.org:8080/#/c/3507/5/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 67: DECLARE_int32(webserver_port); Remove http://gerrit.cloudera.org:8080/#/c/3507/5/be/src/util/webserver.h File be/src/util/webserver.h: PS5, Line 91: BuildUrlString URLs are strings, really, so I think it's fine just to call this "Url()". http://gerrit.cloudera.org:8080/#/c/3507/5/shell/impala_shell.py File shell/impala_shell.py: PS5, Line 863: return long line PS5, Line 873: self._print_if_verbose( : "Query details Web UI: %s/query_plan?query_id=%s" % : (coordinator.webserver_address, self.last_query_handle.id)) I can't remember - what happens here if the query takes a long time to plan (i.e. cold metadata cache)? Will this take a long time to be printed? -- To view, visit http://gerrit.cloudera.org:8080/3507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I704eb64546e27c367830120241311fea6091266b Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
