Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1671: Print time and link to coordinator web UI once query is submitted in shell ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3507/5/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 67: #include "common/names.h" > Remove Done http://gerrit.cloudera.org:8080/#/c/3507/5/be/src/util/webserver.h File be/src/util/webserver.h: PS5, Line 91: Url(); > URLs are strings, really, so I think it's fine just to call this "Url()". Done http://gerrit.cloudera.org:8080/#/c/3507/5/shell/impala_shell.py File shell/impala_shell.py: PS5, Line 863: > long line Done PS5, Line 873: self._print_if_verbose( : "Query details Web UI: %s/query_plan?query_id=%s" % : (coordinator.webserver_address, self.last_query_handle.id)) > I can't remember - what happens here if the query takes a long time to plan Yes unfortunately it will. I see no way around it though if we want the query ID as well. -- To view, visit http://gerrit.cloudera.org:8080/3507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I704eb64546e27c367830120241311fea6091266b Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
