Michael Brown has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3782/1/tests/common/skip.py File tests/common/skip.py: PS1, Line 119: def _is_impalalzo_present(): Move to tests.common.environ ? This module doesn't really contain any other code for actually inspecting the environment but instead imports the necessary symbols to provide appropriate skip conditions. http://gerrit.cloudera.org:8080/#/c/3782/1/tests/data_errors/test_data_errors.py File tests/data_errors/test_data_errors.py: PS1, Line 40: @SkipIfEnvironment.no_impalalzo Is skipping this wholesale the right approach? It seems like we'd want to adjust the test constraints and remove lzo if lzo is not present. This skips all the tests, even dimensions that don't need to be skipped. -- To view, visit http://gerrit.cloudera.org:8080/3782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
