David Knupp has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3782/1/tests/data_errors/test_data_errors.py File tests/data_errors/test_data_errors.py: PS1, Line 40: @SkipIfEnvironment.no_impalalzo > So -- this appears to the case, but perhaps you could correct me, since I'm So, just to double check, I rebuilt Impala both with and without Impala LZO, and ran all of the these tests using exhaustive. In the best case scenario, these are the results: 20 passed, 88 deselected, 124 xfailed Without Impala LZO, the results are these: 20 failed, 88 deselected, 124 xfailed The failures all stem from that same ImpalaBeeswaxException when trying to query functional_text_lzo.bad_text_lzo, regardless of the compression_codec specified. This table is created during the data load. If we skip creating this table during data load, then the same 20 tests fail, but because of another (wholly expected) exception: AnalysisException: Could not resolve table reference: 'functional_text_lzo.bad_text_lzo' In short, there don't seem to be any dimensions in this file that don't need to be skipped. -- To view, visit http://gerrit.cloudera.org:8080/3782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
