Tim Armstrong has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3782/1/tests/data_errors/test_data_errors.py File tests/data_errors/test_data_errors.py: PS1, Line 40: @SkipIfEnvironment.no_impalalzo > Is skipping this wholesale the right approach? It seems like we'd want to a I agree with this - I think we can probably handle most cases by changing the default test dimensions. The decorator is probably useful if there are some tests that somehow depend on Impala-lzo data without it being in the test dimensions. Line 46: # Only run on delimited text with no compression. This comment seems to imply that this isn't run with LZO - is the comment stale? -- To view, visit http://gerrit.cloudera.org:8080/3782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
