Jim Apple has posted comments on this change. Change subject: IMPALA-3898: Add a pytest skipif decorator based on presence of Impala LZO. ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3782/1//COMMIT_MSG Commit Message: Line 11: if Impala LZO isn't present, we want to skip tests that would otherwise How did you test? http://gerrit.cloudera.org:8080/#/c/3782/1/tests/common/skip.py File tests/common/skip.py: PS1, Line 119: def Does this need to be a function in the class? Why not a top-level function? -- To view, visit http://gerrit.cloudera.org:8080/3782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If61a7799205cd00d440196303a42db32c522f5b1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
