Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3857: Add missing synchronization in KuduScanNode ......................................................................
Patch Set 1: > I'm not sure that I understand the scenario. I think this is worth > fixing, but it seems like calling scanner_threads_.JoinAll() would > prevent the scanner threads from living beyond the point when the > exec node and queue were valid. Close() does call scanner_threads_.JoinAll() already. I'd been trying to figure out how a ScannerThread could live past the call to Close() but haven't been able to find anything that really explains it. -- To view, visit http://gerrit.cloudera.org:8080/3888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16be206c60a692d2a26d719de8cc45e859b06e97 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
